Unsubscribe from multiple topics, fix messageId variable name #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we have it support both an array and a single string? Something like if type(topics) is str:
topics = [topics] |
|
Sure, that looks reasonable. I am not a huge fan of these variable "type signatures", but the alternative would be to introduce a wrapper method which is not that great either. Thanks for having a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix messageId variable name when sending unsubscribe requests. Allow sending multiple topics in a single request. This does change the API, but is pretty much in line with subscriptionReceived() and subackReceived().